Add ObservedTimestamp to pdata.LogRecord (open-telemetry#5171)

Resolves open-telemetry#5170
mantian2020 · Apr 11, 2022 · 87ad1ae · 87ad1ae
1 parent 418ae40
commit 87ad1ae
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -19,6 +19,7 @@
 ### 💡 Enhancements 💡
 
 - OTLP HTTP receiver will use HTTP/2 over TLS if client supports it (#5190) 
+- Add `ObservedTimestamp` field to `pdata.LogRecord` (#5171)
 
 ### 🧰 Bug fixes 🧰
 

diff --git a/internal/otlptext/logs.go b/internal/otlptext/logs.go
@@ -45,6 +45,7 @@ func (textLogsMarshaler) MarshalLogs(ld pdata.Logs) ([]byte, error) {
 			for k := 0; k < logs.Len(); k++ {
 				buf.logEntry("LogRecord #%d", k)
 				lr := logs.At(k)
+				buf.logEntry("ObservedTimestamp: %s", lr.ObservedTimestamp())
 				buf.logEntry("Timestamp: %s", lr.Timestamp())
 				buf.logEntry("Severity: %s", lr.SeverityText())
 				buf.logEntry("Body: %s", attributeValueToString(lr.Body()))

diff --git a/model/internal/cmd/pdatagen/internal/log_structs.go b/model/internal/cmd/pdatagen/internal/log_structs.go
@@ -88,6 +88,14 @@ var logRecord = &messageValueStruct{
 	description:    "// LogRecord are experimental implementation of OpenTelemetry Log Data Model.\n",
 	originFullName: "otlplogs.LogRecord",
 	fields: []baseField{
+		&primitiveTypedField{
+			fieldName:       "ObservedTimestamp",
+			originFieldName: "ObservedTimeUnixNano",
+			returnType:      "Timestamp",
+			rawType:         "uint64",
+			defaultVal:      "Timestamp(0)",
+			testVal:         "Timestamp(1234567890)",
+		},
 		&primitiveTypedField{
 			fieldName:       "Timestamp",
 			originFieldName: "TimeUnixNano",

diff --git a/model/internal/generated_log.go b/model/internal/generated_log.go
diff --git a/model/internal/generated_log_test.go b/model/internal/generated_log_test.go