Reduce minimal string length for UserId to 2 in DirectLinkPaymentRequ…

…est (#83) * Update mininal string length check for UserId Reduce minimal string length for UserId to 2 in DirectLinkPaymentRequest See: https://payment-services.ingenico.com/int/en/ogone/support/guides/integration%20guides/directlink/request-a-new%20order#requestparameters * Update DirectLinkPaymentRequestTest.php Set new UserId test value in DirectLinkPaymentRequestTest::provideBadParameters()
marlon-be · Mar 9, 2017 · 28ce8ab · 28ce8ab
1 parent fdd854d
commit 28ce8ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/Ogone/DirectLink/DirectLinkPaymentRequest.php b/lib/Ogone/DirectLink/DirectLinkPaymentRequest.php
@@ -40,7 +40,7 @@ public function getValidOgoneUris()
 
     public function setUserId($userid)
     {
-        if (strlen($userid) < 8) {
+        if (strlen($userid) < 2) {
             throw new InvalidArgumentException("User ID is too short");
         }
         $this->parameters['userid'] = $userid;

diff --git a/tests/Ogone/Tests/DirectLink/DirectLinkPaymentRequestTest.php b/tests/Ogone/Tests/DirectLink/DirectLinkPaymentRequestTest.php
@@ -107,7 +107,7 @@ public function provideBadParameters()
     {
         return array(
             array('setPswd', '12'),
-            array('setUserid', '12'),
+            array('setUserid', '1'),
         );
     }