Make sure Ecommerce Alias is not too long

There is a check already for DirectLink Alias, but it was missing for Ecommerce Alias.
marlon-be · Mar 25, 2016 · 60c71fb · 60c71fb
1 parent a314e13
commit 60c71fb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/Ogone/Ecommerce/Alias.php b/lib/Ogone/Ecommerce/Alias.php
@@ -20,6 +20,10 @@ class Alias
 
     public function __construct($alias, $aliasOperation = self::OPERATION_BY_MERCHANT, $aliasUsage = null)
     {
+        if (strlen($alias) > 50) {
+            throw new InvalidArgumentException("Alias is too long");
+        }
+
         if (preg_match('/[^a-zA-Z0-9_-]/', $alias)) {
             throw new InvalidArgumentException("Alias cannot contain special characters");
         }

diff --git a/tests/Ogone/Tests/Ecommerce/AliasTest.php b/tests/Ogone/Tests/Ecommerce/AliasTest.php
@@ -28,6 +28,15 @@ public function AliasCanHaveOperationByPsp()
         $this->assertEquals(Alias::OPERATION_BY_PSP, $alias->getAliasOperation());
     }
 
+    /**
+     * @test
+     * @expectedException \InvalidArgumentException
+     */
+    public function AliasIsMax50Characters()
+    {
+        new Alias(str_repeat('X', 51));
+    }
+
     /**
      * @test
      * @expectedException \InvalidArgumentException