use hash_equals (#90)

* use hash_equals * keep support for php <5.6 * add missing return statement
marlon-be · Apr 30, 2019 · 9050e50 · 9050e50
1 parent eefe735
commit 9050e50
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/Ogone/DirectLink/CreateAliasResponse.php b/lib/Ogone/DirectLink/CreateAliasResponse.php
@@ -26,7 +26,11 @@ class CreateAliasResponse extends AbstractResponse
      */
     public function isValid(ShaComposer $shaComposer)
     {
-        return $shaComposer->compose($this->parameters) == $this->shaSign;
+        if (function_exists('hash_equals')) {
+            return hash_equals($shaComposer->compose($this->parameters), $this->shaSign);
+        } else {
+            return $shaComposer->compose($this->parameters) == $this->shaSign;
+        }
     }
 
     public function isSuccessful()

diff --git a/lib/Ogone/Ecommerce/EcommercePaymentResponse.php b/lib/Ogone/Ecommerce/EcommercePaymentResponse.php
@@ -23,6 +23,10 @@ class EcommercePaymentResponse extends AbstractPaymentResponse
      */
     public function isValid(ShaComposer $shaComposer)
     {
-        return $shaComposer->compose($this->parameters) == $this->shaSign;
+        if (function_exists('hash_equals')) {
+            return hash_equals($shaComposer->compose($this->parameters), $this->shaSign);
+        } else {
+            return $shaComposer->compose($this->parameters) == $this->shaSign;
+        }        
     }
 }