Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added artifact support for model cov & pdf results. #40

Merged
merged 17 commits into from
Feb 2, 2021

Conversation

nbhoski
Copy link
Member

@nbhoski nbhoski commented Jan 19, 2021

  • Added support for STM result

  • Added support for model coverage

  • Added support for PDF report
    eg:
    `

      displayName: Run MATLAB tests and generate Simulink test artifacts
          inputs:
            selectByFolder: "simtests"
            coberturaModelCoverage: test-results/matlab/modelcoverage.xml
            simulinkTestResults: test-results/matlab/stmResult.mldatx
            testResultsPDF: test-results/matlab/results.pdf`
    

Note: Integ test on self-hosted windows azure instance fails as Simulink is not installed on those windows systems.

Copy link
Member

@mw-hrastega mw-hrastega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small edit.

@mw-hrastega mw-hrastega self-requested a review January 25, 2021 14:08
@cafarm
Copy link

cafarm commented Jan 25, 2021

With the number of options we're offering now, we probably need to start putting them in labeled groups similar to Jenkins. You should be able to do that by adding a groups section to the task.json.

Screen Shot 2021-01-25 at 4 01 08 PM

The "Test results in PDF format" label also feels a bit out of place with the other labels. What if we just copy the group and label names from Jenkins?

Screen Shot 2021-01-25 at 4 43 42 PM

@cafarm
Copy link

cafarm commented Jan 26, 2021

I added Simulink to the scale set agents, so the integ. tests should pass on the self-hosted agents now.

tasks/run-matlab-tests/v0/main.ts Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/main.ts Outdated Show resolved Hide resolved
@nbhoski
Copy link
Member Author

nbhoski commented Jan 27, 2021

With the number of options we're offering now, we probably need to start putting them in labeled groups similar to Jenkins. You should be able to do that by adding a groups section to the task.json.

Screen Shot 2021-01-25 at 4 01 08 PM

The "Test results in PDF format" label also feels a bit out of place with the other labels. What if we just copy the group and label names from Jenkins?

Screen Shot 2021-01-25 at 4 43 42 PM

Agree i have made those changes and it looks like

image

image

Copy link
Member

@mcafaro mcafaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more suggestions.

"Source code folder" should also probably become "Source folder" to be more consistent with Jenkins and the API.

tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
tasks/run-matlab-tests/v0/task.json Outdated Show resolved Hide resolved
@nbhoski
Copy link
Member Author

nbhoski commented Jan 29, 2021

Few more suggestions.

"Source code folder" should also probably become "Source folder" to be more consistent with Jenkins and the API.

Done.

@nbhoski nbhoski requested a review from mcafaro January 29, 2021 09:21
@mcafaro
Copy link
Member

mcafaro commented Feb 1, 2021

Please "Squash and merge" when you're ready.

@nbhoski nbhoski merged commit 76732f3 into master Feb 2, 2021
@mcafaro mcafaro deleted the multi_artifact_support branch February 2, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants