Mention to update cache buster parameter when updating the Matomo font #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
| * Update [plugins/Morpheus/stylesheets/base/icons.css](https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/Morpheus/stylesheets/base/icons.css) and add a new CSS class for this font. The style content in this class needs to mention the font, for example `\e609`. You find the correct value for this from the `style.css` file of the extracted zip file. Simply search for the icon name there to find the correct value. | ||
| * Update [plugins/Morpheus/stylesheets/base/icons.css](https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/Morpheus/stylesheets/base/icons.css) | ||
| * Add a new CSS class for this icon. The style content in this class needs to mention the font character, for example `\e609`. You can find the correct value for this from the `style.css` file of the extracted zip file. Simply search for the icon name there to find the correct value. | ||
| * Update cachebuster parameter of the four font URLs at the top of the file, for example `url('plugins/Morpheus/fonts/matomo.woff2?rzeu9j')` could become `url('plugins/Morpheus/fonts/matomo.woff2?gt43xz')`. The cache buster string can be any six digit random alphanumeric string as long as it's different from the previous one. Providing a new cache buster value will invalidate any old versions of the font in browser caches and force the new font to be used. |
There was a problem hiding this comment.
I've seen cases when the URL query param didn't invalidate for everyone all the time, there might be some obscure proxies etc, but it does work most of the time. The safest way would be to rename the file each time to have the cache-buster param as a part of the actual filename, but that would be a bit too much I reckon.
michalkleiner
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the Matomo font guide with an additional step to update the cache buster values in the icon font URLs to help invalidate browser font caching.
Review