Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fixes #12277 :Disable sending confirmation email when 3pid is disabled #14682

Closed
wants to merge 6 commits into from
Closed

fixes #12277 :Disable sending confirmation email when 3pid is disabled #14682

wants to merge 6 commits into from

Conversation

JeyRathnam
Copy link
Contributor

@JeyRathnam JeyRathnam commented Dec 16, 2022 •
edited
Loading

Signed-off-by: Jeyachandran.rathnam [email protected]

fixes #12277

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@JeyRathnam JeyRathnam changed the title Fixes #12277 :Disable sending confirmation email when 3pid is disabled fixes #12277 :Disable sending confirmation email when 3pid is disabled Dec 16, 2022
@JeyRathnam JeyRathnam marked this pull request as ready for review December 16, 2022 23:31
@JeyRathnam JeyRathnam requested a review from a team as a code owner December 16, 2022 23:31
@JeyRathnam JeyRathnam mentioned this pull request Dec 21, 2022
Closed
@JeyRathnam JeyRathnam closed this Dec 23, 2022
@clokep
Copy link
Member

clokep commented Dec 23, 2022

Replaced by #14725.

DMRobertson pushed a commit that referenced this pull request Jan 9, 2023
@JeyRathnam @clokep
Disable sending confirmation email when 3pid is disabled #14682 (#14725)
5e08880 
* Fixes #12277 :Disable sending confirmation email when 3pid is disabled

* Fix test_add_email_if_disabled test case to reflect changes to enable_3pid_changes flag

* Add changelog file

* Rename newsfragment.

Co-authored-by: Patrick Cloke <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling 3pid changes still sends validation email
2 participants
@JeyRathnam @clokep