Displaying Secret Key in Edit Token section #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be a very useful feature addition, as it would allow to migrate keys to a new device or other app and there is currently no other way doing so (except restore of a full backup - if available). I'd love to see this merged and released! |
tdung
approved these changes
May 3, 2022
tdung
approved these changes
May 3, 2022
|
Any chance of this getting merged and deployed to the store? Just going to run a build from this branch, but I imagine this prevents non-developers from transferring their 2FA secrets to a new device. |
|
Does this just need to be updated with master before merging? Moving to a new device once again and had to checkout this branch for a second time, ha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for editing & exporting it.