Merged
Conversation
mbrt
requested changes
Mar 31, 2022
Owner
mbrt
left a comment
There was a problem hiding this comment.
Overall good! I left some comments but no deal breaker. Thanks for the contribution!
mbrt
requested changes
Apr 1, 2022
492cadc to
4b4f12f
Compare
Contributor
Author
|
Apologies for the additional pushes, some simplifications were staring me in the face very judgementally. |
mbrt
approved these changes
Apr 3, 2022
Owner
|
Looks good, thanks! Please rebase to the latest master. I merged #240 in an attempt to fix the Go workflow. |
Makes for easier-to-read diffs. mbrt#221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes for easier-to-read diffs.
Close #221.