Sourcery refactored master branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-30
to
+34
| if not session.get('logged_in'): | ||
| return flask.redirect(flask.url_for('.login')) | ||
| else: | ||
| return flask.redirect(flask.url_for('.dashboard_panel')) | ||
| return ( | ||
| flask.redirect(flask.url_for('.dashboard_panel')) | ||
| if session.get('logged_in') | ||
| else flask.redirect(flask.url_for('.login')) | ||
| ) |
There was a problem hiding this comment.
Function main_page refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp) - Swap if/else branches of if expression to remove negation (
swap-if-expression)
Comment on lines
-101
to
+105
| if session.get('logged_in') is False: | ||
| return flask.redirect(flask.url_for('.main_page')) | ||
| else: | ||
| if session.get('logged_in') is not False: | ||
| session['logged_in'] = False | ||
| flask_login.logout_user() | ||
| return flask.redirect(flask.url_for('.main_page')) | ||
| return flask.redirect(flask.url_for('.main_page')) |
There was a problem hiding this comment.
Function logout refactored with the following changes:
- Hoist nested repeated code outside conditional statements (
hoist-similar-statement-from-if)
Comment on lines
-127
to
+131
| return flask.flash('Error: %s' % errorIndication) | ||
| return flask.flash(f'Error: {errorIndication}') | ||
| elif errorStatus: | ||
| return flask.flash( | ||
| '%s at %s' % (errorStatus.prettyPrint(), errorIndex and varBinds[int(errorIndex) - 1] or '?') | ||
| f"{errorStatus.prettyPrint()} at {errorIndex and varBinds[int(errorIndex) - 1] or '?'}" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Function MainAPI.get refactored with the following changes:
- Replace interpolated string formatting with f-string [×2] (
replace-interpolation-with-fstring)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.56%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!