Skip to content

Move maps manifest to :feature:map#3444

Merged
jamesarich merged 2 commits intomainfrom
maps_manifest
Oct 13, 2025
Merged

Move maps manifest to :feature:map#3444
jamesarich merged 2 commits intomainfrom
maps_manifest

Conversation

@poliver
Copy link
Member

@poliver poliver commented Oct 12, 2025

@jamesarich this seems to work fine in debug builds, but I'm unable to verify on a release build.

This PR removes manifest redeclarations that are already present in the main app manifest. Maps-related manifest declarations are also moved to :feature:map.

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.39%. Comparing base (e691981) to head (f00213e).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3444   +/-   ##
=====================================
  Coverage   0.39%   0.39%           
=====================================
  Files        299     299           
  Lines      18047   18047           
  Branches    2162    2162           
=====================================
  Hits          71      71           
  Misses     17960   17960           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poliver poliver added enhancement New feature or request modularization Related to project modularization labels Oct 12, 2025
Copy link
Collaborator

@jamesarich jamesarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it out in 2.7.4

@jamesarich jamesarich added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit d4a6c8b Oct 13, 2025
6 checks passed
@jamesarich jamesarich deleted the maps_manifest branch October 13, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request modularization Related to project modularization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants