Skip to content

Fix lint in Main.kt#3484

Merged
poliver merged 2 commits intomainfrom
main_lint
Oct 16, 2025
Merged

Fix lint in Main.kt#3484
poliver merged 2 commits intomainfrom
main_lint

Conversation

@poliver
Copy link
Member

@poliver poliver commented Oct 16, 2025

These have been bugging me for a while. Scaffold padding shouldn't really matter in this case, but string res access may actually not behave correctly due to LocalContext reads not being invalidated on config changes. LocalResources is a better way to access strings in this case.

@poliver poliver added the bugfix PR tag label Oct 16, 2025
@poliver poliver enabled auto-merge October 16, 2025 18:25
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.39%. Comparing base (88ba0aa) to head (1114436).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/src/main/java/com/geeksville/mesh/ui/Main.kt 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3484      +/-   ##
========================================
- Coverage   0.39%   0.39%   -0.01%     
========================================
  Files        300     300              
  Lines      17874   17875       +1     
  Branches    2140    2140              
========================================
  Hits          71      71              
- Misses     17787   17788       +1     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poliver poliver added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 2a4ab2f Oct 16, 2025
7 checks passed
@poliver poliver deleted the main_lint branch October 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant