Skip to content

Fix app cold start jank#3492

Merged
poliver merged 1 commit intomainfrom
app_intro_jank
Oct 17, 2025
Merged

Fix app cold start jank#3492
poliver merged 1 commit intomainfrom
app_intro_jank

Conversation

@poliver
Copy link
Member

@poliver poliver commented Oct 17, 2025

Delay on the appIntroCompleted pref Flow causes the app intro the briefly flash (cold app start) on installations that have already completed it. This PR starts that Flow eagerly to hopefully address the issue.

Before After
before.mp4
after.mp4

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.39%. Comparing base (9f91b73) to head (1921384).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...shtastic/core/datastore/UiPreferencesDataSource.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3492      +/-   ##
========================================
- Coverage   0.39%   0.39%   -0.01%     
========================================
  Files        302     302              
  Lines      17876   17878       +2     
  Branches    2142    2142              
========================================
  Hits          71      71              
- Misses     17789   17791       +2     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poliver poliver added this pull request to the merge queue Oct 17, 2025
Merged via the queue into main with commit e889975 Oct 17, 2025
6 checks passed
@poliver poliver deleted the app_intro_jank branch October 17, 2025 20:19
@poliver poliver added the bugfix PR tag label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant