Skip to content

Remove ktorfit#4019

Merged
jamesarich merged 1 commit intomainfrom
remove_ktorfit
Dec 16, 2025
Merged

Remove ktorfit#4019
jamesarich merged 1 commit intomainfrom
remove_ktorfit

Conversation

@poliver
Copy link
Member

@poliver poliver commented Dec 16, 2025

No sense maintaining a compiler plugin when our use case is so simple. Using Ktor directly is straightforward enough.

@poliver poliver marked this pull request as ready for review December 16, 2025 21:46
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.56%. Comparing base (3783a1e) to head (9304d55).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../meshtastic/core/network/di/GoogleNetworkModule.kt 0.00% 20 Missing ⚠️
.../org/meshtastic/core/network/service/ApiService.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #4019      +/-   ##
========================================
- Coverage   0.56%   0.56%   -0.01%     
========================================
  Files        404     405       +1     
  Lines      24116   24117       +1     
  Branches    3098    3098              
========================================
  Hits         136     136              
- Misses     23959   23960       +1     
  Partials      21      21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich jamesarich added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 4b3ae72 Dec 16, 2025
8 checks passed
@jamesarich jamesarich deleted the remove_ktorfit branch December 16, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants