fix(4269): Add LongTurbo preset name and tests#4273
Merged
jamesarich merged 2 commits intomainfrom Jan 21, 2026
Merged
Conversation
This commit introduces support for the `LONG_TURBO` modem preset by mapping it to the display name "LongTurbo" in the `Channel` model. Additionally, a new test case, `allModemPresetsHaveValidNames`, has been added to `ChannelTest.kt`. This test iterates through all `ModemPreset` enum values to verify that each one is mapped to a valid, non-"Invalid" channel name, ensuring robustness and preventing future regressions. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4273 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 23 23
Branches 7 7
=====================================
Misses 23 23 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces support for the
LONG_TURBOmodem preset by mapping it to the display name "LongTurbo" in theChannelmodel.Additionally, a new test case,
allModemPresetsHaveValidNames, has been added toChannelTest.kt. This test iterates through allModemPresetenum values to verify that each one is mapped to a valid, non-"Invalid" channel name, ensuring robustness and preventing future regressions.resolves #4269