fix(mesh): Set hopStart to match hopLimit in sent packets#4324
Merged
jamesarich merged 2 commits intomainfrom Jan 26, 2026
Merged
fix(mesh): Set hopStart to match hopLimit in sent packets#4324jamesarich merged 2 commits intomainfrom
hopStart to match hopLimit in sent packets#4324jamesarich merged 2 commits intomainfrom
Conversation
This commit updates `MeshCommandSender` to set the `hopStart` field on outgoing `MeshPacket`s to be equal to the `hopLimit`. Previously, `hopStart` was not being explicitly set, leaving it at its default value. This change ensures that the initial hop count is correctly recorded in the packet, which is essential for accurate hop count tracking and debugging within the mesh. The `build` extension function for `MeshPacket` has been modified to set both `hopLimit` and `hopStart` to the resolved hop limit value. New tests have been added to `MeshCommandSenderHopLimitTest` to verify that `hopStart` is correctly set for various packet-sending functions, including `sendToRadio` and `requestUserInfo`. Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
hopStart to match hopLimit in sent packetshopStart to match hopLimit in sent packets
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4324 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 28 28
Branches 8 8
=====================================
Misses 28 28 ☔ View full report in Codecov by Sentry. |
Signed-off-by: James Rich <2199651+jamesarich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates
MeshCommandSenderto set thehopStartfield on outgoingMeshPackets to be equal to thehopLimit.Previously,
hopStartwas not being explicitly set, leaving it at its default value. This change ensures that the initial hop count is correctly recorded in the packet, which is essential for accurate hop count tracking and debugging within the mesh.The
buildextension function forMeshPackethas been modified to set bothhopLimitandhopStartto the resolved hop limit value. New tests have been added toMeshCommandSenderHopLimitTestto verify thathopStartis correctly set for various packet-sending functions, includingsendToRadioandrequestUserInfo.fixes #4308