Fix crash when no logging selected #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryOsterman
requested changes
Jun 4, 2020
src/environment.h
Outdated
| static std::string get_env_variable(std::string env_variable) | ||
| #include <sstream> | ||
|
|
||
| static std::string get_env_variabe_no_log( |
Member
There was a problem hiding this comment.
Instead of taking an "out" parameter and returning a string value, would it make sense to return a std::pair (or std::tuple) with two string values - an error and an environment value? That way the calling signature is the same and you can change the error handling pattern to be auto val = get_env_variable_no_log(xxx); if (!val.second.empty()) { log val.second; }?
src/environment.h
Outdated
| static std::string get_env_variable(std::string env_variable) | ||
| #include <sstream> | ||
|
|
||
| static std::string get_env_variabe_no_log( |
Member
There was a problem hiding this comment.
get_env_variabe_no_log??? Spelling error?
LarryOsterman
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash which would occur if neither the logging callback nor the azure dcap specific environment variable is set and adds a test for this condition
This was tested against Windows Server 2016 and Ubuntu 16