Skip to content

Conversation

@Batta32
Copy link
Contributor

@Batta32 Batta32 commented May 11, 2021

Related to microsoft/botbuilder-java#1165 and microsoft/botbuilder-java#1204

Proposed Changes

We compared the documentation/code migration/behavior of the 49.qnamaker-all-features sample between Java and C# and we found disparities and fixes that this PR includes.

  • Add a verification of the QnA resource of application.properties
  • Update README
  • Clean-up autogenerated files/folder related to Eclipse (e.g. target/.classpath)

Testing

QnA Maker All Features sample working as expected
image

image

@Batta32 Batta32 requested a review from a team as a code owner May 11, 2021 12:44
@Batta32 Batta32 requested review from gabog and munozemilio May 11, 2021 12:44
@LeeParrishMSFT LeeParrishMSFT merged commit 0672efe into microsoft:main May 13, 2021
@Batta32 Batta32 deleted the external/fix/southworks/java/samples/qnamaker-all-features branch May 13, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants