Fix snmalloc linking regression#7161
Merged
achamayou merged 1 commit intomicrosoft:mainfrom Aug 4, 2025
Merged
Conversation
maxtropets
approved these changes
Aug 4, 2025
Member
Author
|
Basic JS, pre and post: 
|
mjp41
added a commit
to mjp41/snmalloc
that referenced
this pull request
Aug 5, 2025
The use of CACHE in the SNMALLOC_STATIC_LIBRARY_PREFIX was not correctly handled by cmake before 3.21. > The “set(CACHE)” command no longer removes a normal variable of the same name, if any. See policy “CMP0126”. Changing the minimum version means that containing projects can do: ```CMake set(SNMALLOC_STATIC_LIBRARY_PREFIX "my_prefix") ``` Without this, there were weird behaviours that the first compile used "sn_" and then subsequent compiles used "my_prefix". Thanks to @achamayou for debugging this in CCF. microsoft/CCF#7161
mjp41
added a commit
to microsoft/snmalloc
that referenced
this pull request
Aug 5, 2025
The use of CACHE in the SNMALLOC_STATIC_LIBRARY_PREFIX was not correctly handled by cmake before 3.21. > The “set(CACHE)” command no longer removes a normal variable of the same name, if any. See policy “CMP0126”. Changing the minimum version means that containing projects can do: ```CMake set(SNMALLOC_STATIC_LIBRARY_PREFIX "my_prefix") ``` Without this, there were weird behaviours that the first compile used "sn_" and then subsequent compiles used "my_prefix". Thanks to @achamayou for debugging this in CCF. microsoft/CCF#7161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for regression introduced in #7137 that resulted in end to end binaries no longer actually using snmalloc, because the setting of SNMALLOC_STATIC_LIBRARY_PREFIX is scoped too narrowly and does not result in a static libraries with the un-prefixed malloc, free etc symbols being produced.