Skip to content

Use Marshal.AddRef/Release/QueryInterface. #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manodasanW merged 1 commit into from
Nov 11, 2023
Merged

Use Marshal.AddRef/Release/QueryInterface. #1379

manodasanW merged 1 commit into from
Nov 11, 2023

Conversation

@jlaanstra
Copy link
Collaborator

@jlaanstra jlaanstra commented Nov 11, 2023

Use Marshal.AddRef/Release/QueryInterface instead of reading ThisPtr twice and casting one to IUnknownVftbl.

Sergio0694
Sergio0694 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@manodasanW manodasanW merged commit 0c65b63 into microsoft:staging/AOT Nov 11, 2023
@jlaanstra jlaanstra deleted the user/jlaans/marshal branch November 17, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jlaanstra @manodasanW @Sergio0694