Add GC.KeepAlive when doing ABI call #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
approved these changes
Oct 26, 2024
manodasanW
added a commit
that referenced
this pull request
Feb 8, 2025
* Try running with GC stress * Also disable * Add GC keep alive * Remove optional * Add KeepAlive * Keep alive * Try increasing timeout to see if it is just taking longer to launch * Diagnose test issue * Try to fix test * Update timeouts * Increase timeout * Try one more fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at some recent crash dumps, it looked like the object / RCW was going away while the function call was happening. This then lead to an AV. Adding GC.KeepAlive throughout to try to avoid this. Also added capability to run tests with GC stress.
Fixes #1022