Skip to content

Improve ICPP exception messages #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
manodasanW merged 2 commits into from
Oct 30, 2024
Merged

Improve ICPP exception messages #1857

manodasanW merged 2 commits into from
Oct 30, 2024

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Oct 30, 2024

This PR includes two small tweaks to the ICPP support:

  • Improves the exception messages for AOT to also mention the property name
  • Avoids a string allocation when retrieving indexer properties on AOT

@Sergio0694 Sergio0694 added debugging Improvements to debugging experience AOT labels Oct 30, 2024
@Sergio0694 Sergio0694 requested a review from manodasanW October 30, 2024 00:19
manodasanW
manodasanW reviewed Oct 30, 2024
View reviewed changes
@Sergio0694 @manodasanW
Fix typo
5f5a683 
Co-authored-by: Manodasan Wignarajah <[email protected]>
@manodasanW manodasanW merged commit 0ca5cd6 into master Oct 30, 2024
@manodasanW manodasanW deleted the user/sergiopedri/improve-icpp-exception-message branch October 30, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodasanW manodasanW manodasanW approved these changes

Assignees

No one assigned

Labels

AOT debugging Improvements to debugging experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sergio0694 @manodasanW