Add vtable entry for covariant IEnumerable<object> for WinRT types too. #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I realized there were other covariance scenarios still broken, made an attempt at solving them all. |
Scottj1s
reviewed
Nov 23, 2020
Scottj1s
reviewed
Nov 23, 2020
Scottj1s
reviewed
Nov 23, 2020
| || type.GetCustomAttribute<WindowsRuntimeTypeAttribute>() is object; | ||
| } | ||
|
|
||
| // Use TryGetCompatibleWindowsRuntimeTypesForVariantType instead. |
Member
Author
There was a problem hiding this comment.
No, the issue is this API was marked public even though we only used it internally. Since we don't expect anyone else to use it or for it to be used in cross module scenarios, we can accept the breaking change and remove the old version of the API. But before I did that, I wanted to make sure there weren't concerns with that, so I instead put a comment.
Scottj1s
reviewed
Nov 23, 2020
Scottj1s
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a more complete covariant support. For covariant interfaces, we get all the possible types that can be passed for the generic and create a vtable entry for them. Along with that, if the generic is itself a covariant interface, we do the same for it.
For now, I haven't removed the previous version of this function as it was a public function.
Fixes #592
Fixes #598