Adding Get-GitHubRelease#125
Conversation
|
|
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks so much for this contribution. And those tests! Well done. Some minor requested changes, and then we should be good to merge in.
Tests/GitHubReleases.tests.ps1
Outdated
| $releases = Get-GitHubRelease -OwnerName $ownerName -RepositoryName $repositoryName | ||
|
|
||
| Context 'When getting all releases' { | ||
|
|
There was a problem hiding this comment.
nit: Please remove this empty line.
GitHubReleases.ps1
Outdated
|
|
||
| if(-not [String]::IsNullOrEmpty($Tag)) | ||
| { | ||
| $telemetryProperties['Tag'] = Get-PiiSafeString -PlainText $Tag |
There was a problem hiding this comment.
| $telemetryProperties['Tag'] = Get-PiiSafeString -PlainText $Tag | |
| $telemetryProperties['ProvidedTag'] = $true | |
| ``` #Resolved |
GitHubReleases.ps1
Outdated
| $telemetryProperties['Latest'] = Get-PiiSafeString -PlainText "latest" | ||
|
|
||
| $uriFragment += "/latest" | ||
| $description = "Getting releases for $OwnerName/$RepositoryName/releases/latest" |
There was a problem hiding this comment.
| $description = "Getting releases for $OwnerName/$RepositoryName/releases/latest" | |
| $description = "Getting latest release for $OwnerName/$RepositoryName" | |
| ``` #Resolved |
|
/azp run PowerShellForGitHub-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I've tried to incorporate all the changes that you've suggested. But, I'm pretty new to git and even newer to github. I've updated the code base There's an updated version of the code at master...ucsb:master. Should I submit a new pull request? |
No need to submit a new PR. We just continue with this one. Sorry for not responding sooner. I missed your comments from Sunday. I'll take a look at all of the updates soon (within the next few days). |
HowardWolosky
left a comment
There was a problem hiding this comment.
Great updates.
Very minor changes requested to your examples, and then this should be good for merging. Thanks for doing this work!
|
So ... I kept trying to use the "Commit Suggestion" button on the web interface, and I must have been doing something wrong because it just wouldn't commit. Anyways, I went to the source and made the "owner" --> "default configured" changes and have updated my github repo. Give it another perusal when you have a chance. Thanks! |
HowardWolosky
left a comment
There was a problem hiding this comment.
This looks great!
Thanks so much for adding this feature.
Congrats on getting in your first change!
I'll publish out a new release in the next couple days that includes this change (I'm currently working on getting that publishing step fully automated).
|
Thanks! I feel bad asking this, but I was wondering if you’ve had a moment to complete this merge? |
Sorry for the delay, @smaglio81. I'm mid-process of automating the whole release pipeline, and the merging/publishing of this change will be used to validate that new automation. So, expect it to be merged in this week. Thanks for your patience! |
Similar to #110, I needed some functionality around releases. I didn't so much need functionality to publish a release, but I needed to retrieve the list of releases that we're published. So, this is just a function for Get-GitHubRelease.