Add ability to rename a repository: Rename-GitHubRepository#145
Add ability to rename a repository: Rename-GitHubRepository#145HowardWolosky merged 6 commits intomicrosoft:masterfrom mtboren:master
Conversation
|
|
HowardWolosky
left a comment
There was a problem hiding this comment.
Thanks so much for doing this, Matt! Very much appreciated!
Thanks as well for writing the extra test and verifying ScriptAnalyzer results as well.
I have some minor feedback for you here to address, but overall, this looks solid. Looking forward to adding it!
Updating the examples to be more uniform (and admittedly slightly less fun) Co-Authored-By: Howard Wolosky <HowardWolosky@users.noreply.github.com>
…is ParamSet, fix style on curly brace, update call to JSON conversion
|
Howdy, @HowardWolosky -- wanted to be sure that you saw that these are now ready for your re-review. Let me know if anything else catches your eye. Summary: I made the edits you pointed out, added another test, re-ran PSScriptAnalyzer, and re-ran the Pester tests. Yay. Cheers |
|
Thanks for the update. Will review this PR later this week. |
HowardWolosky
left a comment
There was a problem hiding this comment.
Matt!
Great update. Thanks so much for handling all of that prior feedback. Just a few tiny further update requests, and then we'll be ready to merge to master.
|
Yes, I'll get those in this week (back now from vacation) |
…e in certain use cases
|
Howdy again, @HowardWolosky -- These are now ready for your re-re-review. Let me know what else, if anything. Summary: I made the edits you pointed out, re-ran PSScriptAnalyzer, and re-ran the Pester tests. Yay. Cheers |
|
Hello, @HowardWolosky Just bumping this to make sure it's still somewhere on the radar. Looking forward to when there is time to return to this PR Cheers |
|
Apologies for that. Missed your previous bump. Will get to the review this week. Thanks for your patience. |
HowardWolosky
left a comment
There was a problem hiding this comment.
Really minor remaining feedback. Otherwise, this is good to go.
I'm considering adding that confirmation logic to Remove-GitHubRepository as well, but it would be a breaking change for users, so I likely wouldn't do it until after we've hit 1.0 (a major version change).
Remove extraneous blank lines, rename vars to remove Hungarian notation Co-Authored-By: Howard Wolosky <HowardWolosky@users.noreply.github.com>
|
Greets, @HowardWolosky - Feedback incorporated/committed. Let me know if there are any other tidbits. Else, looking forward to the merge! |
HowardWolosky
left a comment
There was a problem hiding this comment.
🎆 This is great. Thanks so much for the contribution, Matt! 🎆
Looking forward to seeing more contributions from you in the future.
I'll get an update with this change published today or tomorrow.
|
This has now been published. |
|
Woo-hoo! Thanks much for working through getting this added. I'm glad to have been able to help a bit. And, hurray for the quick publish, too! See you 'round the community.. |
This adds the ability to easily rename a repository via the new cmdlet
Rename-GitHubRepository, as suggested in #144 . As we see in the diff, this PR:Running
PSScriptAnalyzerreturns no issue (returned$null), andPestertest results were unchanged except that there is now one new, successful test.How does this look as an add to this great module?