Skip to content

Allow callers of Invoke-GHRestMethod[MultipleResult] to specify additional headers#319

Merged
HowardWolosky merged 1 commit intomicrosoft:masterfrom
HowardWolosky:additionalHeaders
Mar 20, 2021
Merged

Allow callers of Invoke-GHRestMethod[MultipleResult] to specify additional headers#319
HowardWolosky merged 1 commit intomicrosoft:masterfrom
HowardWolosky:additionalHeaders

Conversation

@HowardWolosky
Copy link
Copy Markdown
Contributor

Description

When experimenting with the the notifications API, it was necessary to be able to specify an additional header (If-Modified-Since).

Making this support generic by allowing callers to specify any number of additional headers to be included with the REST request.

Issues Fixed

n/a

References

Notifications API (although this doesn't actually implement anything from there)

Checklist

  • You actually ran the code that you just wrote, especially if you did just "one last quick change".
  • Comment-based help added/updated, including examples.
  • Static analysis is reporting back clean.
  • New/changed code adheres to our coding guidelines.
  • Formatters were created for any new types being added.
  • New/changed code continues to support the pipeline.
  • Changes to the manifest file follow the manifest guidance.
  • Unit tests were added/updated and are all passing. See testing guidelines. This includes making sure that all pipeline input variations have been covered.
  • Relevant usage examples have been added/updated in USAGE.md.
  • If desired, ensure your name is added to our Contributors list

…ional headers

When experimenting with the the notifications API, it was necessary
to be able to specify an additional header (If-Modified-Since).

Making this support generic by allowing callers to specify any number
of additional headers to be included with the REST request.
@HowardWolosky HowardWolosky merged commit a2329d6 into microsoft:master Mar 20, 2021
@HowardWolosky HowardWolosky deleted the additionalHeaders branch March 20, 2021 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant