Prevent ConvertTo-SmarterObject from flattening arrays#56
Merged
HowardWolosky merged 6 commits intomicrosoft:masterfrom Nov 30, 2018
Merged
Prevent ConvertTo-SmarterObject from flattening arrays#56HowardWolosky merged 6 commits intomicrosoft:masterfrom
ConvertTo-SmarterObject from flattening arrays#56HowardWolosky merged 6 commits intomicrosoft:masterfrom
Conversation
* Ensure that `ConvertTo-SmarterObject` does not cause any side-effects on `InputObject` * Ensure that `ConvertTo-SmarterObject` does not flatten any arrays * Switched all calls to `ConvertTo-Json` to not use pipelining in order to avoid PowerShell's array-flattening logic when piping the InputObject in, as opposed to when passing it as a parameter. * Ensured that we do best-effort Date conversion in `ConvertTo-SmarterObject` (a failed date conversion should never cause an exception/failure). * Used a workaround described in [Pester's Wiki](# https://github.com/pester/Pester/wiki/Testing-different-module-types) to force the module to be a `Script Module` instead of a `Manifest Module` so that `Mock` and `InModuleScope` (which lets you test private methods) work. * Added UT's for `ConvertTo-SmarterObject` core scenarios. Resolves microsoft#55: ConvertTo-SmarterObject is flattening arrays NOTE: Two tests still failing (legitimately). Still a work in progress.
Consistently use System.Collections.IList in ConvertTo-SmarterObject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConvertTo-SmarterObjectdoes not cause any side-effects onInputObjectConvertTo-SmarterObjectdoes not flatten any arraysConvertTo-Jsonto not use pipelining in order to avoid PowerShell'sarray-flattening logic when piping the InputObject in, as opposed to when passing it as a parameter.
ConvertTo-SmarterObject(a failed date conversionshould never cause an exception/failure).
to force the module to be a
Script Moduleinstead of aManifest Moduleso thatMockandInModuleScope(which lets you test private methods) work.ConvertTo-SmarterObjectcore scenarios.Resolves PowerShell#55: ConvertTo-SmarterObject is flattening arrays
Thanks to @danbelcher-MSFT for the assist on this one.