Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Conversation

@fran893
Copy link
Contributor

@fran893 fran893 commented Apr 16, 2021

Fixes #1130

Description

The temporal recognizers-text folder present in the repository doesn't contain the unit tests that the Recognizers-Text repository contains. With these changes the code coverage is improved.

Specific Changes

  • Add Specs folder
  • Add timex-expressions unit tests
  • Add datetime unit tests
  • Add sequence unit tests
  • Add numberwithunit unit tests
  • Add number unit tests
  • Add choice unit tests
  • Add text unit tests
  • Update bot-dialogs pom to use UTF-8 to execute unit tests correctly just like Recognizers-Text

Testing

Code coverage before adding unit tests
image

Code coverage after adding unit tests
image

mvn clean install of the entire repository
image

@tracyboehrer tracyboehrer merged commit 80849cf into microsoft:main Apr 16, 2021
tracyboehrer pushed a commit that referenced this pull request Apr 16, 2021
…ral Recognizer-Text folder in bot-dialogs library (#1168)

* Add timex-expression unit tests

* Add Specs folder

* Add datetime unit tests

* Add sequence unit tests

* Add number with unit unit tests

* Add number unit tests

* Add choice unit tests

* Add text unit tests

* Update bot-dialogs pom to use UTF-8 to execute unit tests correctly

Co-authored-by: Martin Battaglino <[email protected]>
@Batta32 Batta32 deleted the external/southworks/recognizers-text/add-unit-tests branch April 16, 2021 14:48
tracyboehrer added a commit that referenced this pull request Apr 16, 2021
* [SDK][Recognizers-Text] Add Recognizer-Text unit tests into the temporal Recognizer-Text folder in bot-dialogs library (#1168)

* Add timex-expression unit tests

* Add Specs folder

* Add datetime unit tests

* Add sequence unit tests

* Add number with unit unit tests

* Add number unit tests

* Add choice unit tests

* Add text unit tests

* Update bot-dialogs pom to use UTF-8 to execute unit tests correctly

Co-authored-by: Martin Battaglino <[email protected]>

* [SDK][Recognizers-Text] Update temporal folder with latest changes (#1164)

* Update Datetime extractors

* Update Datetime resources

* Update Number resources

* Update NumberWithUnit resources

* Update NumberWithUnit extractors

* Update NumberWithUnit parsers

Co-authored-by: Franco Alvarez <[email protected]>
Co-authored-by: Martin Battaglino <[email protected]>
tracyboehrer added a commit that referenced this pull request Apr 26, 2021
* Update main branch and readme.md version (#1153)

* Added snapshot support to parent POM (#1157)

* Corrected type and path of UserToken.exchangeToken (#1159)

* Update CODE_OF_CONDUCT.md

update to april 19th content

* [SDK][Recognizers-Text] Update temporal folder with latest changes (#1164)

* Update Datetime extractors

* Update Datetime resources

* Update Number resources

* Update NumberWithUnit resources

* Update NumberWithUnit extractors

* Update NumberWithUnit parsers

* Implement TeamsSSOExchangeMiddleware and fixes to associated dependency areas. (#1167)

* Implement TeamsSSOExchangeMiddleware

* Fixes for Cosmos, OAuthPrompt, and TokenExchange

* [SDK][Recognizers-Text] Add Recognizer-Text unit tests into the temporal Recognizer-Text folder in bot-dialogs library (#1168)

* Add timex-expression unit tests

* Add Specs folder

* Add datetime unit tests

* Add sequence unit tests

* Add number with unit unit tests

* Add number unit tests

* Add choice unit tests

* Add text unit tests

* Update bot-dialogs pom to use UTF-8 to execute unit tests correctly

Co-authored-by: Martin Battaglino <[email protected]>

* Support for Recognizer tests on MacOS. (#1173)

* Updated pom.xml to enable Jacoco output (#1175)

* Add additional unit test coverage (#1185)

* Activity Unit Tests

* additional unit tests

* Remove surefire entry from dialogs pom.xml

* Update surefire entry in pom.xml

* Additional tests and fixes.

* Additional unit tests and fixes.

* Additional tests

* Update pom.xml for release version.

* Fix surefire args

Co-authored-by: tracyboehrer <[email protected]>
Co-authored-by: Scott Gellock <[email protected]>
Co-authored-by: Martin Battaglino <[email protected]>
Co-authored-by: Franco Alvarez <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests for Recognizers

4 participants