Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions etc/bot-checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@

<module name="SuppressWarningsFilter" />

<module name="LineLength">
<property name="max" value="120"/>
</module>

<module name="TreeWalker">
<!-- check for usage of literal equality "==" between string -->
<module name="StringLiteralEquality"/>
Expand Down Expand Up @@ -125,10 +129,7 @@
</module>

<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
<module name="LineLength">
<property name="max" value="120"/>
</module>
<!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
<module name="MethodLength"/>
<module name="ParameterNumber"/>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ public void setService(T withService) {
this.service = withService;
}

@Override
/**
* Adds the associated object or service to the current turn context.
* @param turnContext The context object for this turn.
* @param next The delegate to call to continue the bot middleware pipeline.
*/
@Override
public CompletableFuture<Void> onTurn(TurnContext turnContext, NextDelegate next) {
if (!StringUtils.isBlank(key)) {
turnContext.getTurnState().add(key, service);
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<jdk.version>1.8</jdk.version>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
<checkstyle.version>3.1.0</checkstyle.version>
<checkstyle.version>3.1.2</checkstyle.version>
<pmd.version>3.14.0</pmd.version>
<exclude.tests>%regex[.*recognizers.*]</exclude.tests>
<!-- <repo.id>MyGet</repo.id> -->
Expand Down