Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Switched to using OffsetDateTime instead of String for Teams meeting …
…models
  • Loading branch information
tracyboehrer committed Jun 24, 2021
commit 0a278318f26eb2a4cfafcc4a86d1c49bafe93089
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,7 @@ protected CompletableFuture<Void> onTeamsMeetingStart(
TurnContext turnContext
) {
record.add("onTeamsMeetingStart");
return turnContext.sendActivity(meeting.getStartTime())
return turnContext.sendActivity(meeting.getStartTime().toString())
.thenCompose(resourceResponse -> super.onTeamsMeetingStart(meeting, turnContext));
}

Expand All @@ -1312,7 +1312,7 @@ protected CompletableFuture<Void> onTeamsMeetingEnd(
TurnContext turnContext
) {
record.add("onTeamsMeetingEnd");
return turnContext.sendActivity(meeting.getEndTime())
return turnContext.sendActivity(meeting.getEndTime().toString())
.thenCompose(resourceResponse -> super.onTeamsMeetingEnd(meeting, turnContext));
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
package com.microsoft.bot.schema.teams;

import com.fasterxml.jackson.annotation.JsonProperty;
import java.time.OffsetDateTime;

/**
* Specific details of a Teams meeting.
Expand All @@ -13,10 +14,10 @@ public class MeetingDetails extends MeetingDetailsBase {
private String msGraphResourceId;

@JsonProperty(value = "scheduledStartTime")
private String scheduledStartTime;
private OffsetDateTime scheduledStartTime;

@JsonProperty(value = "scheduledEndTime")
private String scheduledEndTime;
private OffsetDateTime scheduledEndTime;

@JsonProperty(value = "type")
private String type;
Expand Down Expand Up @@ -45,7 +46,7 @@ public void setMsGraphResourceId(String withMsGraphResourceId) {
*
* @return The meeting's scheduled start time, in UTC.
*/
public String getScheduledStartTime() {
public OffsetDateTime getScheduledStartTime() {
return scheduledStartTime;
}

Expand All @@ -54,7 +55,7 @@ public String getScheduledStartTime() {
*
* @param withScheduledStartTime The meeting's scheduled start time, in UTC.
*/
public void setScheduledStartTime(String withScheduledStartTime) {
public void setScheduledStartTime(OffsetDateTime withScheduledStartTime) {
scheduledStartTime = withScheduledStartTime;
}

Expand All @@ -63,7 +64,7 @@ public void setScheduledStartTime(String withScheduledStartTime) {
*
* @return The meeting's scheduled end time, in UTC.
*/
public String getScheduledEndTime() {
public OffsetDateTime getScheduledEndTime() {
return scheduledEndTime;
}

Expand All @@ -72,7 +73,7 @@ public String getScheduledEndTime() {
*
* @param withScheduledEndTime The meeting's scheduled end time, in UTC.
*/
public void setScheduledEndTime(String withScheduledEndTime) {
public void setScheduledEndTime(OffsetDateTime withScheduledEndTime) {
scheduledEndTime = withScheduledEndTime;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,28 @@
package com.microsoft.bot.schema.teams;

import com.fasterxml.jackson.annotation.JsonProperty;
import java.time.OffsetDateTime;

/**
* Specific details of a Teams meeting end event.
*/
public class MeetingEndEventDetails extends MeetingDetails {
@JsonProperty(value = "EndTime")
private String endTime;
private OffsetDateTime endTime;

/**
* Gets the meeting's end time, in UTC.
* @return The meeting's end time, in UTC.
*/
public String getEndTime() {
public OffsetDateTime getEndTime() {
return endTime;
}

/**
* Sets the meeting's end time, in UTC.
* @param withEndTime The meeting's end time, in UTC.
*/
public void setEndTime(String withEndTime) {
public void setEndTime(OffsetDateTime withEndTime) {
endTime = withEndTime;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,27 +4,28 @@
package com.microsoft.bot.schema.teams;

import com.fasterxml.jackson.annotation.JsonProperty;
import java.time.OffsetDateTime;

/**
* Specific details of a Teams meeting start event.
*/
public class MeetingStartEventDetails extends MeetingEventDetails {
@JsonProperty(value = "StartTime")
private String startTime;
private OffsetDateTime startTime;

/**
* Gets the meeting's start time, in UTC.
* @return The meeting's start time, in UTC.
*/
public String getStartTime() {
public OffsetDateTime getStartTime() {
return startTime;
}

/**
* Sets the meeting's start time, in UTC.
* @param withStartTime The meeting's start time, in UTC.
*/
public void setStartTime(String withStartTime) {
public void setStartTime(OffsetDateTime withStartTime) {
startTime = withStartTime;
}
}