Dialog: Animate when opening and closing #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2016 14:24
dzearing
approved these changes
Nov 11, 2016
Member
dzearing
left a comment
There was a problem hiding this comment.
Minor feedback/questions. Awesome to see this.
src/components/Dialog/Dialog.tsx
Outdated
|
|
||
| public componentDidMount() { | ||
| if (this.state.isOpen) { | ||
| this._async.setTimeout(() => { |
Member
There was a problem hiding this comment.
possible to use onAnimationEnd event?
Contributor
Author
There was a problem hiding this comment.
This was copied over from Panel.tsx but it's redundant in this case. I've removed it, so we're just using onAnimationEnd now.
| } | ||
|
|
||
| private _onDialogRef(ref: HTMLDivElement) { | ||
| if (ref) { |
Member
There was a problem hiding this comment.
Can you use onAnimationEnd in react 15+?
Contributor
Author
There was a problem hiding this comment.
Looks like the onAnimationEnd handler was added for React 15. Here's the pull request.
gokunymbus
pushed a commit
to gokunymbus/office-ui-fabric-react
that referenced
this pull request
Jan 24, 2017
* Animate the Dialog in * Animate the Dialog out * Remove unnecessary timeout and add clarifying comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
This PR adds a fade in animation when the Dialog is opened, and a fadeOut animation when it's closed.