Avoid holding locks in winhttp_http_task completion callback handling when calling into websocket event functions #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ividual callback type handlers to avoid holding onto lock when calling into externally provided event handlers
jasonsandlin
approved these changes
May 13, 2021
jplafonta
reviewed
May 13, 2021
| HRESULT hr = HCHttpCallRequestGetUrl(pRequestContext->m_call, &method, &url); | ||
| if (SUCCEEDED(hr)) | ||
| { | ||
| win32_cs_autolock autoCriticalSection(&pRequestContext->m_lock); |
Contributor
There was a problem hiding this comment.
Should this be release prior to calling complete_task? Does that synchronously call back into client's code?
Contributor
Author
There was a problem hiding this comment.
It looks like it can, but XSAPI doesn't currently use this. I've updated the PR to not hold locks for complete_task.
| _In_ winhttp_http_task* pRequestContext, | ||
| _In_ void* statusInfo) | ||
| { | ||
| win32_cs_autolock autoCriticalSection(&pRequestContext->m_lock); |
…code synchronously
…atiskan/libHttpClient into user/natiskan/callbackdeadlock
natiskan
commented
May 13, 2021
jplafonta
approved these changes
May 14, 2021
natiskan
added a commit
that referenced
this pull request
May 18, 2021
… when calling into websocket event functions (#580) * Move winhttp_http_task completion_callback lock handling into the individual callback type handlers to avoid holding onto lock when calling into externally provided event handlers * Move duplicate XAsyncComplete checking to compete_task * tabs -> spaces * don't hold lock for complete_task since it can call back into client code synchronously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid holding locks in winhttp_http_task when calling into externally provided event handler functions on completion callback.