Skip to content

Fix for Android build on NDK versions 27+ #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplafonta merged 2 commits into from
Apr 2, 2025
Merged

Fix for Android build on NDK versions 27+ #871

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb7ef9e
Fix for Android build on NDK versions 27+
jplafonta Apr 1, 2025
ba7b2db
Merge branch 'main' into user/johlafo/AndroidBuildFix
jplafonta Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Build/libHttpClient.Android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ if (NOT DEFINED HC_NOZLIB)
"${PATH_TO_ROOT}/External/zlib"
"${PATH_TO_ROOT}/External/zlib/contrib/minizip"
)

set_source_files_properties(
"${PATH_TO_ROOT}/External/zlib/contrib/minizip/ioapi.c"
PROPERTIES COMPILE_DEFINITIONS "MINIZIP_FOPEN_NO_64=1"
)
endif()

set(COMMON_INCLUDE_DIRS
Expand All @@ -107,6 +112,11 @@ set(ANDROID_INCLUDE_DIRS
"${PATH_TO_ROOT}/External/opensslGeneratedHeaders/android"
)

add_compile_options(
$<$<COMPILE_LANGUAGE:CXX>:-Wno-error=implicit-function-declaration>
$<$<COMPILE_LANGUAGE:C>:-Wno-error=implicit-function-declaration>
)

#########################
### Set up static lib ###
#########################
Expand Down