DO NOT REVIEW -- Testing validation workflow (2) #9996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19dd6e9 to
12623df
Compare
12623df to
f737010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing a theory. I noticed that despite the validation build failing consistently on HeeJae's PR, when it ran on main after he merged the PR, it passed. I also noticed that the validation builds for all of Eric's recent PRs (which also passed) were from
microsoft/pyrightbranches rather than branches from his fork. So perhaps the failure only occurs when running on branches from forks. The PR where I added CFS authentication was also from an upstream (rather than fork) branch -- #9837.This test PR is based on a branch that I pushed to
microsoft/pyrightrather than my fork.