You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Code folding incorrectly matches to an inactive } #5429
Code folding is lexer based. It doesn't know the values of preprocessor conditions. It looks like VS is initially folding this incorrectly as well, but doing another folding pass after inactive regions are available. We might be able to do something similar, but need a way to trigger VS Code to request ranges from us again (without having to edit the document). I've sent them a question on this, and am waiting for a reply.
Although the blocking issue has been addressed by VS Code, it's still in insiders and not yet available in a general release. This will need to be delayed until the next VS Code release. This will also involve a dependency on that new VS Code version.
Activity
Colengms commentedon May 7, 2020
Code folding is lexer based. It doesn't know the values of preprocessor conditions. It looks like VS is initially folding this incorrectly as well, but doing another folding pass after inactive regions are available. We might be able to do something similar, but need a way to trigger VS Code to request ranges from us again (without having to edit the document). I've sent them a question on this, and am waiting for a reply.
Colengms commentedon Jun 15, 2020
This is blocked on: microsoft/vscode#99914
Colengms commentedon Oct 22, 2020
Taking this out of tracking, as the blocking VS Code issue has been fixed.
Colengms commentedon Oct 28, 2020
Although the blocking issue has been addressed by VS Code, it's still in insiders and not yet available in a general release. This will need to be delayed until the next VS Code release. This will also involve a dependency on that new VS Code version.
Colengms commentedon Nov 10, 2020
The type we need is not yet present in @types/vscode 1.51.0. It's expected to be in 1.52.0.