Skip to content

Update issue templates - #2087

Merged
Pierson Lee (pieandcakes) merged 5 commits into
masterfrom
pieandcakes-patch-1
Jun 4, 2018
Merged

Pierson Lee (pieandcakes) merged 5 commits into
masterfrom
pieandcakes-patch-1

Conversation

@pieandcakes

Copy link
Copy Markdown
Contributor

No description provided.

@bobbrow

Bob Brown (bobbrow) commented Jun 4, 2018 •

Copy link
Copy Markdown
Contributor

I'm confused as to what the difference is between [tag]-issue.md and [tag].md is. They look like duplicates of each other. Is there a reason for this that I just don't understand? Is one supposed to be a feature request and the other a bug?


**Additional context**
*Call Stacks: For bugs like crashes, deadlocks, infinite loops, etc. that we are not able to repro and for which the call stack may be useful, please attach a debugger and/or create a dmp and provide the call stacks. Starting with 0.17.3, Windows binaries have symbols available in VS Code by setting your "symbolSearchPath" to "http://msdl.microsoft.com/download/symbols".*
Add any other context about the problem here including log messages in your Output window ("C_Cpp.loggingLevel": "Information" in settings.json).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to list "Debug" instead of "Information" for the logging level

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it out of the current template. Is it supposed to be "debug" ?

Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smartphone?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a lot of boilerplate left in these templates. Can you remove the stuff that doesn't apply?

Comment thread .github/ISSUE_TEMPLATE/bug_report.md Outdated

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Browser matters

@pieandcakes

Copy link
Copy Markdown
Contributor Author

Bob Brown (@bobbrow) I'll see what i can do. I used their tool within the repo and it created the templates.

@bobbrow

Copy link
Copy Markdown
Contributor

Are we going to add a feature request template too?

@pieandcakes

Copy link
Copy Markdown
Contributor Author

Bob Brown (@bobbrow) Most of our feature requests come from bug reports, which will filter to which section that feature will be for. I would suggest starting with an Issue template and marking it with a label as a feature request.

@bobbrow Bob Brown (bobbrow) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general template has some stuff that should be removed.

- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove smartphone section

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove desktop section (duplicate info as the Describe section)

@WardenGnaw

Copy link
Copy Markdown
Member

With the new templates, I would remove ISSUE_TEMPLATE.md

@bobbrow Bob Brown (bobbrow) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@pieandcakes
Pierson Lee (pieandcakes) merged commit 7729d0a into master Jun 4, 2018
@pieandcakes
Pierson Lee (pieandcakes) deleted the pieandcakes-patch-1 branch June 4, 2018 23:54
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants