Repository navigation
Update package-lock and fix new linter errors. - #2412
Merged
Sean McManus (sean-mcmanus) merged 2 commits intoAug 16, 2018
Merged
Conversation
Sean McManus (sean-mcmanus)
requested review from
Bob Brown (bobbrow) and
Griffin Downs (grdowns)
August 16, 2018 16:34
Contributor
Author
|
Does the package-lock look correct to you or did I do something incorrect? It appears to have fixed the url-parse vulnerability. I'll add a task to update our gulp dev dependencies. |
Contributor
|
That doesn't look right. I see no edits to package.json. I remember your clone having trouble with this... |
Contributor
Author
|
I deleted my node_modules and tried again, but I get the same results -- I think it's because it's a level 2 dependency, so it doesn't require a modification of our package.json dependencies. |
Bob Brown (bobbrow)
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.