Skip to content

Update package-lock and fix new linter errors. - #2412

Merged
Sean McManus (sean-mcmanus) merged 2 commits into
masterfrom
seanmcm/fixUrlParseDependency
Aug 16, 2018
Merged

Sean McManus (sean-mcmanus) merged 2 commits into
masterfrom
seanmcm/fixUrlParseDependency

Conversation

@sean-mcmanus

Copy link
Copy Markdown
Contributor

No description provided.

@sean-mcmanus

Sean McManus (sean-mcmanus) commented Aug 16, 2018 •

Copy link
Copy Markdown
Contributor Author

Does the package-lock look correct to you or did I do something incorrect? It appears to have fixed the url-parse vulnerability. I'll add a task to update our gulp dev dependencies.

@bobbrow

Copy link
Copy Markdown
Contributor

That doesn't look right. I see no edits to package.json. I remember your clone having trouble with this...

@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

I deleted my node_modules and tried again, but I get the same results -- I think it's because it's a level 2 dependency, so it doesn't require a modification of our package.json dependencies.

@sean-mcmanus
Sean McManus (sean-mcmanus) deleted the seanmcm/fixUrlParseDependency branch August 16, 2018 16:59
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants