Repository navigation
Add capabilities. - #7486
Add capabilities.#7486
Conversation
|
Switching "untrustedWorkspaces" from false to "limited" is a TODO task for 1.5.0. |
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "c_cpp.capabilities.untrustedWorkspaces.description": "Multiple settings can cause processes local to the workspace to be executed, e.g. C_Cpp.clang_format_path, C_Cpp.addNodeAddonIncludePaths, C_Cpp.default.compilerPath, C_Cpp.default.configurationProvider, and C_Cpp.default.compileCommands, and the equivalent properties in c_cpp_properties.json.", | |||
There was a problem hiding this comment.
I don't think configuration provider counts because the trust support is delegated to that extension, and we don't explicitly activate it for the user.
Do we also need to mention the debugger paths supported by launch.json?
There was a problem hiding this comment.
Well, I take it back about config provider since it does send a compiler path back to us
There was a problem hiding this comment.
The question is whether we can trust the config provider?
There was a problem hiding this comment.
No -- debugger stuff is already disabled with untrusted workspaces.
There was a problem hiding this comment.
If they have a configuration provider set, then the workspace itself (cmake or makefile) could reference a compiler path that is local to the workspace folder, so technically the cmake or makefile extensions would not be the ones that are executing the untrusted code, it would be our extension.
Handle #7483 (virtualWorkspaces) and microsoft/vscode#120251 (untrustedWorkspaces)