Skip to content

Add capabilities. - #7486

Merged
Sean McManus (sean-mcmanus) merged 2 commits into
mainfrom
seanmcm/disableVirtualWorkspaces
May 14, 2021
Merged

Sean McManus (sean-mcmanus) merged 2 commits into
mainfrom
seanmcm/disableVirtualWorkspaces

Conversation

@sean-mcmanus

@sean-mcmanus Sean McManus (sean-mcmanus) commented May 7, 2021 •

Copy link
Copy Markdown
Contributor

Handle #7483 (virtualWorkspaces) and microsoft/vscode#120251 (untrustedWorkspaces)

@sean-mcmanus
Sean McManus (sean-mcmanus) requested a review from a team May 7, 2021 20:21
@sean-mcmanus

Copy link
Copy Markdown
Contributor Author

Switching "untrustedWorkspaces" from false to "limited" is a TODO task for 1.5.0.

@@ -1,4 +1,5 @@
{
"c_cpp.capabilities.untrustedWorkspaces.description": "Multiple settings can cause processes local to the workspace to be executed, e.g. C_Cpp.clang_format_path, C_Cpp.addNodeAddonIncludePaths, C_Cpp.default.compilerPath, C_Cpp.default.configurationProvider, and C_Cpp.default.compileCommands, and the equivalent properties in c_cpp_properties.json.",

@bobbrow Bob Brown (bobbrow) May 7, 2021 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think configuration provider counts because the trust support is delegated to that extension, and we don't explicitly activate it for the user.

Do we also need to mention the debugger paths supported by launch.json?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I take it back about config provider since it does send a compiler path back to us

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is whether we can trust the config provider?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No -- debugger stuff is already disabled with untrusted workspaces.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they have a configuration provider set, then the workspace itself (cmake or makefile) could reference a compiler path that is local to the workspace folder, so technically the cmake or makefile extensions would not be the ones that are executing the untrusted code, it would be our extension.

@sean-mcmanus
Sean McManus (sean-mcmanus) deleted the seanmcm/disableVirtualWorkspaces branch May 14, 2021 02:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants