Skip to content

Fix typo in package.json - #7508

Merged
Bob Brown (bobbrow) merged 1 commit into
microsoft:coleng/walkthroughfrom
jogo-:patch-1
May 11, 2021
Merged

Bob Brown (bobbrow) merged 1 commit into
microsoft:coleng/walkthroughfrom
jogo-:patch-1

Conversation

@jogo-

@jogo- jogo- commented May 11, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@bobbrow
Bob Brown (bobbrow) merged commit 5a0d0a6 into microsoft:coleng/walkthrough May 11, 2021
@bobbrow Bob Brown (bobbrow) added this to the 1.4.0 milestone May 11, 2021
@bobbrow

Copy link
Copy Markdown
Contributor

Oops. I didn't notice this was going into the coleng/walkthrough branch. Could you target your PR's into main?

@jogo-
jogo- deleted the patch-1 branch May 11, 2021 16:22
@jogo-

jogo- commented May 11, 2021

Copy link
Copy Markdown
Contributor Author

No, not possible. This PR can only target the coleng/walkthrough WIP branch so far.

@sean-mcmanus

Copy link
Copy Markdown
Contributor

That's fine -- I think Colen will be submitting a PR for his branch soon. Usually spelling fixes would be mentioned in a code review at the time the PR is submitted.

@bobbrow

Copy link
Copy Markdown
Contributor

I didn't expect anyone outside our team to find a working branch and make suggestions on an in-flight feature prior to PR, so I thought that the target branch was a mistake. I didn't pay as much attention on what was actually being changed - just that the spelling looked correct.

@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants