Repository navigation
Add Getting Started Walkthrough #7512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
118a4a7
Initial walkthrough text
Colengms d4fd651
Update walkthrough to used json schema used by latest VS Code insiders
Colengms 7d258ab
Fix typo
Colengms b4d26b3
Fix buttons
Colengms 5d9b7bf
Add compiler check
Colengms 384fd2b
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
Colengms c1ed0b7
Fix compile error
Colengms 7ba1935
added newlines and starter markdown files
jureid 0fcb815
added placeholder screenshots and updated markdown files
jureid 27e20d7
Add check for workspaceFolderCount
Colengms 68278a6
Merge branch 'coleng/walkthrough' of https://github.com/microsoft/vsc…
Colengms 1b810d4
added screenshots for different color themes
jureid 652056b
updated success message for checking compiler
jureid 96da1ce
Add compiler name to no.compilers.found
Colengms 3b56d3d
Add missing semicolon
Colengms 1b8a25c
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
Colengms 07eb6ef
Add an arg to config UI/JSON commands to accept ViewColumn
Colengms 73c49de
Merge branch 'main' of https://github.com/microsoft/vscode-cpptools i…
Colengms 5a0d0a6
Fix typo in package.json (#7508)
jogo- 83a90c3
updated content for build and debug tasks. added command for installi…
jureid f8457c1
Merge branch 'coleng/walkthrough' of https://github.com/microsoft/vsc…
jureid ee364b8
fixed rendering issues
jureid c873bc0
Fix typo in install-compiler-windows.md (#7509)
jogo- a1ff74b
updated markdown files
jureid 1cb5ba9
updated markdown files
jureid 445c81d
fixed formatting for second note in install compiler on windows file
jureid e6b16eb
final edits to markdown files
jureid b96e527
removed ... from buttons in walkthrough
jureid f84412d
Add doneOn for walkthrough commands. Done for links is tracked by vs…
Colengms f9d8907
Address PR feedback
Colengms 824fe36
Address PR feedback
Colengms 94d0266
addressing PR feedback
jureid dff8d69
fixed capitalizaiton issue in two markdown files, fixed altText for c…
jureid 379f2e5
Switch from using doneOn to completionEvents
Colengms 96b9900
Fix slash directions in compiler check UI
Colengms 0b51a9a
Fix lint issues
Colengms 3c50562
updated screenshots and created subfolders
jureid 5f1a3c1
Merge branch 'main' into coleng/walkthrough
Colengms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -596,11 +596,12 @@ export interface Client { | |
| handleConfigurationProviderSelectCommand(): Promise<void>; | ||
| handleShowParsingCommands(): Promise<void>; | ||
| handleReferencesIcon(): void; | ||
| handleConfigurationEditCommand(): void; | ||
| handleConfigurationEditJSONCommand(): void; | ||
| handleConfigurationEditUICommand(): void; | ||
| handleConfigurationEditCommand(viewColumn?: vscode.ViewColumn): void; | ||
| handleConfigurationEditJSONCommand(viewColumn?: vscode.ViewColumn): void; | ||
| handleConfigurationEditUICommand(viewColumn?: vscode.ViewColumn): void; | ||
| handleAddToIncludePathCommand(path: string): void; | ||
| handleGoToDirectiveInGroup(next: boolean): Promise<void>; | ||
| handleCheckForCompiler(): Promise<void>; | ||
| onInterval(): void; | ||
| dispose(): void; | ||
| addFileAssociations(fileAssociations: string, languageId: string): void; | ||
|
|
@@ -2620,16 +2621,16 @@ export class DefaultClient implements Client { | |
| } | ||
| } | ||
|
|
||
| public handleConfigurationEditCommand(): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditCommand(undefined, vscode.window.showTextDocument)); | ||
| public handleConfigurationEditCommand(viewColumn: vscode.ViewColumn = vscode.ViewColumn.Active): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditCommand(undefined, vscode.window.showTextDocument, viewColumn)); | ||
| } | ||
|
|
||
| public handleConfigurationEditJSONCommand(): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditJSONCommand(undefined, vscode.window.showTextDocument)); | ||
| public handleConfigurationEditJSONCommand(viewColumn: vscode.ViewColumn = vscode.ViewColumn.Active): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditJSONCommand(undefined, vscode.window.showTextDocument, viewColumn)); | ||
| } | ||
|
|
||
| public handleConfigurationEditUICommand(): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditUICommand(undefined, vscode.window.showTextDocument)); | ||
| public handleConfigurationEditUICommand(viewColumn: vscode.ViewColumn = vscode.ViewColumn.Active): void { | ||
| this.notifyWhenLanguageClientReady(() => this.configuration.handleConfigurationEditUICommand(undefined, vscode.window.showTextDocument, viewColumn)); | ||
| } | ||
|
|
||
| public handleAddToIncludePathCommand(path: string): void { | ||
|
|
@@ -2660,6 +2661,31 @@ export class DefaultClient implements Client { | |
| } | ||
| } | ||
|
|
||
| public async handleCheckForCompiler(): Promise<void> { | ||
| await this.awaitUntilLanguageClientReady(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated to this PR, but this naming seems odd since the method itself doesn't "await"...not sure what a better name would be though. |
||
| const compilers: configs.KnownCompiler[] | undefined = await this.getKnownCompilers(); | ||
|
Colengms marked this conversation as resolved.
Resolved
sean-mcmanus marked this conversation as resolved.
Resolved
|
||
| if (!compilers || compilers.length === 0) { | ||
| const compilerName: string = process.platform === "win32" ? "MSVC" : (process.platform === "darwin" ? "Clang" : "GCC"); | ||
|
jureid marked this conversation as resolved.
Resolved
|
||
| vscode.window.showInformationMessage(localize("no.compilers.found", "No C++ compilers were found on your system. For your platform, we recommend installing {0} using the instructions in the editor.", compilerName), { modal: true }); | ||
| } else { | ||
| const header: string = localize("compilers.found", "We found the following C++ compiler(s) on your system:"); | ||
|
jureid marked this conversation as resolved.
Resolved
|
||
| let message: string = header + "\n"; | ||
| const settings: CppSettings = new CppSettings(this.RootUri); | ||
| const pathSeparator: string | undefined = settings.preferredPathSeparator; | ||
| compilers.forEach(compiler => { | ||
| if (pathSeparator !== "Forward Slash") { | ||
| message += "\n" + compiler.path.replace(/\//g, '\\'); | ||
| } else { | ||
| message += "\n" + compiler.path.replace(/\\/g, '/'); | ||
| } | ||
| }); | ||
| if (compilers.length > 1) { | ||
| message += "\n\n" + localize("compilers.found.message", "You can specify which compiler to use in your project's IntelliSense Configuration."); | ||
| } | ||
| vscode.window.showInformationMessage(message, { modal: true }); | ||
| } | ||
| } | ||
|
|
||
| public onInterval(): void { | ||
| // These events can be discarded until the language client is ready. | ||
| // Don't queue them up with this.notifyWhenLanguageClientReady calls. | ||
|
|
@@ -2823,11 +2849,12 @@ class NullClient implements Client { | |
| handleConfigurationProviderSelectCommand(): Promise<void> { return Promise.resolve(); } | ||
| handleShowParsingCommands(): Promise<void> { return Promise.resolve(); } | ||
| handleReferencesIcon(): void {} | ||
| handleConfigurationEditCommand(): void {} | ||
| handleConfigurationEditJSONCommand(): void {} | ||
| handleConfigurationEditUICommand(): void {} | ||
| handleConfigurationEditCommand(viewColumn?: vscode.ViewColumn): void {} | ||
| handleConfigurationEditJSONCommand(viewColumn?: vscode.ViewColumn): void {} | ||
| handleConfigurationEditUICommand(viewColumn?: vscode.ViewColumn): void {} | ||
| handleAddToIncludePathCommand(path: string): void { } | ||
| handleGoToDirectiveInGroup(next: boolean): Promise<void> { return Promise.resolve(); } | ||
| handleCheckForCompiler(): Promise<void> { return Promise.resolve(); } | ||
| onInterval(): void {} | ||
| dispose(): void { | ||
| this.booleanEvent.dispose(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.