Skip to content

Conversation

@apollo13
Copy link
Contributor

@apollo13 apollo13 commented Oct 6, 2023

Python 3.7 is EOL and according to the readme only "active" python versions are supported. I think I found all occurrences of python 3.7 :)

@apollo13
Copy link
Contributor Author

apollo13 commented Oct 6, 2023

@microsoft-github-policy-service agree

@apollo13
Copy link
Contributor Author

apollo13 commented Oct 6, 2023

One thing that this PR does not do is update NOTICE.txt, seems as if zipp and colorama is no longer required according to pip-compile

EDIT:// yeah colorama is only required on windows: https://github.com/pytest-dev/pytest/blob/54623f0f33c367e19c4041d30f11f71787e30719/setup.cfg#L50 -- if this is wanted, someone with a windows machine would have to regenerate the requirements :)

@karthiknadig karthiknadig self-requested a review November 2, 2023 17:05
@karthiknadig karthiknadig self-assigned this Nov 2, 2023
@karthiknadig karthiknadig added the debt Technical debt or repo cleanup label Nov 2, 2023
karthiknadig
karthiknadig previously approved these changes Nov 2, 2023
karthiknadig
karthiknadig previously approved these changes Nov 2, 2023
@apollo13
Copy link
Contributor Author

apollo13 commented Nov 2, 2023

Okay, the windows tests are failing due to colorama not being in the generated requirements. Can someone with windows recreate those files? Personally I think the whole approach is flawed since the generated lock files are environment specific… In the worst case linux could require a library named X and windows a library named Y

@karthiknadig
Copy link
Member

I will generate.

@karthiknadig karthiknadig enabled auto-merge (squash) November 2, 2023 18:13
@karthiknadig karthiknadig merged commit 7b7bf7f into microsoft:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt or repo cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants