refactor: separate trace capturing runs and fix trace upload #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Validated the flow in https://vscodeteam.slack.com/archives/C04JHUDNGPK/p1740756993348429 Following command was used, |
bpasero
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #23
Trace files were not uploaded since the tracking count was confused by the heap runs that delete the trace directory before start of the new session. In my local testing, I had disabled the heap runs hence this was not caught.
Separating out the trace runs into a separate session makes the logic simpler and avoids the need to specify
--runtime-tracemanually on the machines, we currently do 2 runs to ensure cache data is applied and upload the trace from the second run.