Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

first commit #2

wants to merge 1 commit into from

Conversation

abhie06
Copy link

@abhie06 abhie06 commented Oct 21, 2022

No description provided.

@abhi1918
Copy link

Isn't there any advanced classification techniques like Convolutional neural network available for classification?

@Laiba2511
Copy link

What is the accuracy of all the algorithms?

@abhie06
Copy link
Author

abhie06 commented Oct 27, 2022

What is the accuracy of all the algorithms?
Most algorithms have similar accuracy but decision tree gives the highest accuracy

@abhie06
Copy link
Author

abhie06 commented Oct 27, 2022

Isn't there any advanced classification techniques like Convolutional neural network available for classification?

No but we will provide it to test it's accuracy against basic classification techniques

@abhie06
Copy link
Author

abhie06 commented Oct 27, 2022

Is there any suggestions?

y = np.array(df['Prediction'])[:-future_days]

x_train, x_test, y_train, y_test = train_test_split(X, y, test_size=0.25)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using the variable X in valid = df[X.shape[0]:], but it's not defined anywhere in the given code. I guess you should use X_train. And also the predictions array is being assigned to the valid DataFrame's 'Predictions' column through the line valid['Predictions'] = predictions. Assigning values to a new column in a slice may not function as intended because valid is produced as a slice of the original DataFrame df. You can make a new DataFrame just for the forecasts to get around this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants