Upgrade dependencies, including handlebars-rust 4.x.#58
Merged
Conversation
mkantor
commented
Jun 13, 2021
| ContentLoadingError::IOError { source, name } | ||
| } | ||
| })?; | ||
| .register_template_file(&template_name, content.absolute_path) |
Owner
Author
There was a problem hiding this comment.
To avoid handlebars-rust needing to reopen the file, I could instead read content.file into a String and use register_template_string here. That might be more efficient, but I haven't benchmarked the two approaches against each other (since this only impacts startup time it isn't super important).
I went with the register_template_file approach because it's simpler and because it opens up the option of using dev_mode, which could be useful until #9 is fully addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are the release notes for handlebars-rust.