Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let select the reporter from the options json object in runner.js #2

Closed
wants to merge 3 commits into from

Conversation

oelmekki
Copy link

@oelmekki oelmekki commented Nov 3, 2010

Hello,

This change is related to cpojer/jasmine-node#1

It let the user call the runner like :
./runner.js '{ "reporter": "junit" }'

@cpojer
Copy link
Member

cpojer commented Nov 4, 2010

Thanks! I've pulled in your changes and optimized them a bit. If anything, it would be awesome if you could adjust your coding style to the MooTools standards for the next time - but as long as there are awesome contributions I have no issues cleaning it up myself =) Thanks again!

@oelmekki
Copy link
Author

oelmekki commented Nov 4, 2010

Woops, my bad. I felt like the runner stuff was quite off mootools common practices. Sorry about that :P

Btw, all the awesomeness of this is due to larrymyers jasmine-reporters, i've just adapted it for mootools-runner.

See ya

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants