Fixes #31 - the Slick.find(element, '~ div') bug #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. |
|
This fixes the problem but we still need a better fix. On selectors with comma, like "node, some" the expression will become "#slickid__ node, some" and it will not work properly. It fixes the current issue, but we still have this bug (that's present on 1.3.1). I think the only way is by parsing the selector before using QSA... but it's not that simple... we need some extra stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of this optimization (ddbcb6e#L1R286) the contexts id was temporarily changed to #slickid__, and #slickid__ was added to the expression. However to make ~ and + work the context should move one node upwards.
I added some specs and tested this in Chrome and only some nth selector specs are failing...