Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slick: Correct invalid selectors in various SlickSpec specs. [jddalton] #36

Closed
wants to merge 1 commit into from
Closed

slick: Correct invalid selectors in various SlickSpec specs. [jddalton] #36

wants to merge 1 commit into from

Conversation

jdalton
Copy link

@jdalton jdalton commented Apr 4, 2011

No description provided.

@subtleGradient
Copy link
Member

There's some good stuff in here.
I don't want to just comment out a bunch of stuff though.
Let's either remove them or not.

As far as invalid selectors go, many engines are intentionally lenient about that stuff.
How would you recommend including tests for selectors that are not W3C valid?

@jdalton
Copy link
Author

jdalton commented Apr 5, 2011

I would make a separate spec file for them, maybe a custom spec. As a side note on leniency, the correct valid selectors should be promoted as they will work on the QSA fork without having to fallback to the manual dom iteration fork of engines.

@jdalton jdalton closed this Jun 30, 2014
@SergioCrisostomo
Copy link
Member

@jdalton why did you close this? (something else than the "age" factor?)

@jdalton
Copy link
Author

jdalton commented Jun 30, 2014

Just pruning dead PRs (those that have been open several years).

@SergioCrisostomo
Copy link
Member

@jdalton well I can't blame you... but if they are good ideas would be better to have them open.
I was actually checking the specs last week and was thinking of putting them on travis like Fabio once suggested. Core has no Slick specs, so we still need this.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants