Skip to content

Conversation

@lotas
Copy link
Contributor

@lotas lotas commented Oct 10, 2023

Switch to checks API.

Also test build pipeline, why tasks are deadline expired

Switch to checks API.

Also test build pipeline, why tasks are deadline expired

Update .taskcluster.yml

trigger rerun
@abpostelnicu
Copy link
Contributor

@lotas what is this suppose to do?

@lotas
Copy link
Contributor Author

lotas commented Oct 12, 2023

@lotas what is this suppose to do?

Github initially had Statuses API only, that was the default option, where jobs would be attached to the commit directly (iirc) and were quite limited.
They later introduced Checks API, and it has more features. For example those runs can now be seen on the PR level:
https://github.com/mozilla/code-review/pull/1920/checks (extra tab) and also allows to attach extra information like description (task logs) and annotations that you could see in the github UI.
It would also allow to use re-run from github UI to retry failed tasks

@abpostelnicu
Copy link
Contributor

@lotas is this safe to merge?

@lotas
Copy link
Contributor Author

lotas commented Oct 12, 2023

We fixed community-tc config here: https://github.com/taskcluster/community-tc-config/pull/688/files
so this project can use extra scope queue:route:checks
And FxCI tasks seems to be running just fine, so should be safe yes.

Merged similar on code-coverage also mozilla/code-coverage#2112

@abpostelnicu abpostelnicu merged commit a9c6cca into mozilla:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants