fix(display): allow text selection under markup annotations #20563
+69
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zilla#18190) Add pointer-events: none to markup annotation containers to prevent blocking text selection. Add integration test.
6a433b8 to
b4476d9
Compare
bcolsson
approved these changes
Jan 12, 2026
|
Not sure if you intended to flag l10n for review or something else. It doesn't look like localization is affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18190.
This PR addresses a regression where text underneath highlight, underline, squiggly, and strikeout annotations could not be selected.
The cause was
pointer-events: autoon the annotation container elements, which blocked mouse events from reaching the text layer.Changes:
pointer-events: noneto.highlightAnnotation,.underlineAnnotation,.squigglyAnnotation, and.strikeoutAnnotationinweb/annotation_layer_builder.css.test/integration/highlight_selection_spec.mjsto verify that the pointer-events property is correctly set to 'none'.Verification: