Skip to content

Don't use contents stream which have an image format #20570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timvandermeij merged 1 commit into from
Jan 13, 2026
Merged

Don't use contents stream which have an image format #20570

timvandermeij merged 1 commit into from
Jan 13, 2026
+30 −2

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Jan 13, 2026

The original bug has been filled in mupdf bug tracker:
https://bugs.ghostscript.com/show_bug.cgi?id=709033

The attached pdf can be open in Chrome but not in Acrobat.

@calixteman
Don't use contents stream which have an image format
b5ed988 
The original bug has been filled in mupdf bug tracker:
https://bugs.ghostscript.com/show_bug.cgi?id=709033

The attached pdf can be open in Chrome but not in Acrobat.
@calixteman
Copy link
Contributor Author

calixteman commented Jan 13, 2026

/botio test

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2c7c32839ce0f26/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/477846d9780153e/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2c7c32839ce0f26/output.txt

Total script time: 41.93 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/2c7c32839ce0f26/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 13, 2026

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b2c729ff380934b/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b2c729ff380934b/output.txt

Total script time: 0.99 mins

Published

timvandermeij
timvandermeij approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing Windows tests. Thank you for improving this!

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/477846d9780153e/output.txt

Total script time: 82.03 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/477846d9780153e/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit f40ab1a into mozilla:master Jan 13, 2026
13 of 14 checks passed
@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 13, 2026

/botio makeref

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/52aedd143c70e6c/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e064ed3e6ad3fdc/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/52aedd143c70e6c/output.txt

Total script time: 18.83 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 13, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/e064ed3e6ad3fdc/output.txt

Total script time: 33.69 mins

  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij